pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2813: Removed Validation Annotations and do manual Validation
Date Mon, 22 Oct 2018 19:49:55 GMT
jerrypeng commented on a change in pull request #2813: Removed Validation Annotations and do
manual Validation
URL: https://github.com/apache/pulsar/pull/2813#discussion_r227063452
 
 

 ##########
 File path: pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java
 ##########
 @@ -218,24 +218,14 @@ public void testExecuteWithLateTupleStream() throws Exception {
     @Test
     public void testSettingSlidingCountWindow() throws Exception {
         final Object[][] args = new Object[][]{
-                {-1, 10},
 
 Review comment:
   This is confusing to me since now there is also a test "testSettingSlidingCountWindow"
in WindowConfigUtilsTest that is kind of doing to same thing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message