pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2813: Removed Validation Annotations and do manual Validation
Date Mon, 22 Oct 2018 19:48:23 GMT
jerrypeng commented on a change in pull request #2813: Removed Validation Annotations and do
manual Validation
URL: https://github.com/apache/pulsar/pull/2813#discussion_r226881791
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutor.java
 ##########
 @@ -100,7 +99,6 @@ private WindowConfig getWindowConfigs(Context context) {
 
 
         WindowUtils.inferDefaultConfigs(windowConfig);
-        ValidatorImpls.WindowConfigValidator.validateWindowConfig(windowConfig);
 
 Review comment:
   why are we removing this check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message