pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2807: Source/Sink Endpoint validations
Date Thu, 18 Oct 2018 18:01:08 GMT
jerrypeng commented on a change in pull request #2807: Source/Sink Endpoint validations
URL: https://github.com/apache/pulsar/pull/2807#discussion_r226407986
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
 ##########
 @@ -288,43 +293,57 @@ public Response updateFunction(final String tenant, final String namespace,
fina
     }
 
     public Response deregisterFunction(final String tenant, final String namespace, final
String functionName,
-            String clientRole) {
+            String sourceName, String sinkName, String clientRole) {
 
 Review comment:
   ok I guess that is fine for right now. I am concerned here since the code logic is complex
and bugs can be easily introduced (especially by developers that didn't originally work on
this) that will break all three.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message