pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on issue #2615: Azure offloader
Date Mon, 15 Oct 2018 10:24:24 GMT
ivankelly commented on issue #2615: Azure offloader
URL: https://github.com/apache/pulsar/pull/2615#issuecomment-429792261
 
 
   To restate what I said on other channels, the refactor should be broken out and submitted
before the new code, as reviewing a refactor requires a different thought process to reviewing
new code. It would be good if the new offloaders could each be in their own PRs so that each
PR can be focussed on a single thing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message