pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2762: Fix IdentitySerde
Date Wed, 10 Oct 2018 13:15:36 GMT
srkukarni commented on a change in pull request #2762: Fix IdentitySerde
URL: https://github.com/apache/pulsar/pull/2762#discussion_r224069876
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/functions/serde.py
 ##########
 @@ -68,9 +68,9 @@ def deserialize(self, input_bytes):
       return pickle.loads(input_bytes)
 
 class IdentitySerDe(SerDe):
-  """Pickle based serializer"""
+  """utf-8 based identity serializer"""
 
 Review comment:
   I think IdentitySerde is a bad name(probably should have been called simple serde).
   I didn't rename it to preserve backwards compatibility(not sure whether its worth preserving)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message