pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2756: Do not create any producer if the output type of a function is void
Date Wed, 10 Oct 2018 01:07:43 GMT
srkukarni commented on a change in pull request #2756: Do not create any producer if the output
type of a function is void
URL: https://github.com/apache/pulsar/pull/2756#discussion_r223910364
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
 ##########
 @@ -235,6 +239,7 @@ public void open(Map<String, Object> config, SinkContext sinkContext)
throws Exc
 
     @Override
     public void write(Record<T> record) throws Exception {
+        if (record == null) return;
 
 Review comment:
   I think the JavaInstanceRunnable is probably a better check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message