pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2685: [schema] introduce AUTO_PRODUCE schema
Date Mon, 01 Oct 2018 18:42:47 GMT
ivankelly commented on a change in pull request #2685:  [schema] introduce AUTO_PRODUCE schema
URL: https://github.com/apache/pulsar/pull/2685#discussion_r221714923
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleTypedProducerConsumerTest.java
 ##########
 @@ -459,7 +461,7 @@ public void testAvroProducerAndAutoSchemaConsumer() throws Exception
{
        }
 
        Consumer<GenericRecord> consumer = pulsarClient
-           .newConsumer(Schema.AUTO())
+           .newConsumer(Schema.AUTO_CONSUME())
 
 Review comment:
   AVRO and JSON take arguments though. A static method that takes no arguments is effectively
a constant, and if it's not, it's doing something very suspicious in the background.
   
   Anyhow, I wouldn't hold up the change for it, but I think it would be better as a constant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message