pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed on a kubernetes cluster
Date Mon, 01 Oct 2018 18:17:54 GMT
srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed
on a kubernetes cluster
URL: https://github.com/apache/pulsar/pull/1950#discussion_r221707094
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
 ##########
 @@ -379,7 +424,11 @@ public Response stopFunctionInstances(String tenant, String namespace,
String fu
      * It stops all functions instances owned by current worker
      * @throws Exception
      */
-    public void stopAllOwnedFunctions() throws Exception {
+    public void stopAllOwnedFunctions() {
+        if (runtimeFactory.externallyManaged()) {
 
 Review comment:
   this function is called during exit of the worker(either unplanned or planned). At this
point we don't really want the functions to die. Thus this check.
   When the function reassignment happens, a new worker will get this assignment, and try
starting the service, which will result in conflict which is then treated as function running
by the k8 runtime. Thus the function is not started and yet the worker will have the right
notion that it exists

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message