From commits-return-15257-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Sep 28 06:15:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1C2CA180652 for ; Fri, 28 Sep 2018 06:15:16 +0200 (CEST) Received: (qmail 60081 invoked by uid 500); 28 Sep 2018 04:15:16 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 60065 invoked by uid 99); 28 Sep 2018 04:15:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2018 04:15:16 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] aahmed-se commented on a change in pull request #2578: Add support for schema extraction from a jar Message-ID: <153810811537.5412.4349523743774149678.gitbox@gitbox.apache.org> Date: Fri, 28 Sep 2018 04:15:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit aahmed-se commented on a change in pull request #2578: Add support for schema extraction from a jar URL: https://github.com/apache/pulsar/pull/2578#discussion_r221137689 ########## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ########## @@ -34,6 +38,7 @@ public CmdSchemas(PulsarAdmin admin) { jcommander.addCommand("get", new GetSchema()); jcommander.addCommand("delete", new DeleteSchema()); jcommander.addCommand("upload", new UploadSchema()); + jcommander.addCommand("pojo", new PojoSchema()); Review comment: we can probably rename it extract if that makes more sense if we combine it with it upload the parameters combinations they will have to be manually managed since there we no longer have required parameter annotations as they will be two distinct groups of params. @srkukarni ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services