From commits-return-14464-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Sat Sep 15 07:35:16 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A3AC318067A for ; Sat, 15 Sep 2018 07:35:15 +0200 (CEST) Received: (qmail 18997 invoked by uid 500); 15 Sep 2018 05:35:14 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 18973 invoked by uid 99); 15 Sep 2018 05:35:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Sep 2018 05:35:14 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on issue #2588: Preserve filename of the original function submission Message-ID: <153698971417.8188.16819823531769131741.gitbox@gitbox.apache.org> Date: Sat, 15 Sep 2018 05:35:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on issue #2588: Preserve filename of the original function submission URL: https://github.com/apache/incubator-pulsar/pull/2588#issuecomment-421532863 There are two failures related to this PR. please take a look. ``` org.apache.pulsar.functions.worker.rest.api.v2.FunctionApiV2ResourceTest.testRegisterFunctionFileUrlWithValidSinkClass org.apache.pulsar.functions.worker.rest.api.v2.FunctionApiV2ResourceTest.testUpdateFunctionWithUrl ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services