From commits-return-14104-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Fri Sep 7 18:18:54 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C8EF618077A for ; Fri, 7 Sep 2018 18:18:53 +0200 (CEST) Received: (qmail 44700 invoked by uid 500); 7 Sep 2018 16:18:52 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 44691 invoked by uid 99); 7 Sep 2018 16:18:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2018 16:18:52 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar Message-ID: <153633713234.7329.16380609500897905249.gitbox@gitbox.apache.org> Date: Fri, 07 Sep 2018 16:18:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2544 These mocks were moved out of pulsar to the bookkeeper project a few months ago. While it is good to have mocks generally available for bookkeeper, if the mock is not in the pulsar code base and we want to change the behaviour of the mock for a specific case, we need to wait for a bookkeeper release cycle to do so. It's better to have the mock in Pulsar, so we can bend it to our needs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services