pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat opened a new pull request #2679: Add types comment in Prometheus stats
Date Sun, 30 Sep 2018 06:25:59 GMT
merlimat opened a new pull request #2679: Add types comment in Prometheus stats
URL: https://github.com/apache/pulsar/pull/2679
 
 
   ### Motivation
   
   While metrics types are optional in the Prometheus format (and ignored by Prometheus server),
some external tools (eg: DataDog) are failing to ingest the metrics exported by Pulsar broker
in Prometheus format. 
   
   The reason is that we use a custom exporter and we don't mark the metrics types, such as
the Prometheus regular libraries are doing.
   
   ### Modifications
   
    * Ensure metric type is printed, once, before the metric is printed
    * Removed space after comma in labels. While this is parsed correctly by all implementation,
the spec doesn't actually allow a space in that position.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message