pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aahmed-se commented on a change in pull request #2578: Add support for schema extraction from a jar
Date Fri, 28 Sep 2018 04:15:15 GMT
aahmed-se commented on a change in pull request #2578: Add support for schema extraction from
a jar
URL: https://github.com/apache/pulsar/pull/2578#discussion_r221137689
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
 ##########
 @@ -34,6 +38,7 @@ public CmdSchemas(PulsarAdmin admin) {
         jcommander.addCommand("get", new GetSchema());
         jcommander.addCommand("delete", new DeleteSchema());
         jcommander.addCommand("upload", new UploadSchema());
+        jcommander.addCommand("pojo", new PojoSchema());
 
 Review comment:
   we can probably rename it extract if that makes more sense if we combine it with it upload
the parameters combinations they will have to be manually managed since there we no longer
have required parameter annotations as they will be two distinct groups of params.
   @srkukarni 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message