pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jiazhai commented on a change in pull request #2615: Azure offloader
Date Thu, 27 Sep 2018 04:09:30 GMT
jiazhai commented on a change in pull request #2615: Azure offloader
URL: https://github.com/apache/pulsar/pull/2615#discussion_r220788592
 
 

 ##########
 File path: tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/BlobStoreTestBase.java
 ##########
 @@ -88,9 +88,9 @@ public void start() throws Exception {
     @AfterMethod
     public void tearDown() {
         if (blobStore != null &&
-            (Boolean.parseBoolean(System.getProperty("testRealAWS", "false")) ||
-             Boolean.parseBoolean(System.getProperty("testRealGCS", "false")) || 
-             Boolean.parseBoolean(System.getProperty("testRealAzure", "false")))) {
+            (!Boolean.parseBoolean(System.getProperty("testRealAWS", "false")) ||
 
 Review comment:
   "||" should be "&&" ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message