pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2612: Allow byte[] keys for messages (#1016)
Date Wed, 19 Sep 2018 20:42:29 GMT
sijie commented on a change in pull request #2612: Allow byte[] keys for messages (#1016)
URL: https://github.com/apache/incubator-pulsar/pull/2612#discussion_r218956364
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/TypedMessageBuilder.java
 ##########
 @@ -89,6 +89,14 @@
      */
     TypedMessageBuilder<T> key(String key);
 
+    /**
+     * Sets the bytes of the key of the message for routing policy.
+     * Internally the bytes will be base64 encoded.
+     *
+     * @param key routing key for message, in byte array form
+     */
+    TypedMessageBuilder<T> keyBytes(byte[] key);
 
 Review comment:
   any particular reason on naming this `keyBytes` instead of `key`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message