pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie closed pull request #2599: [java-client] Issue #2384: ConnectionHandler: Log stack trace instead of printing
Date Tue, 18 Sep 2018 10:05:42 GMT
sijie closed pull request #2599: [java-client] Issue #2384: ConnectionHandler: Log stack trace
instead of printing
URL: https://github.com/apache/incubator-pulsar/pull/2599
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java
index d9bdc74faa..d04e8a847a 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java
@@ -71,7 +71,6 @@ protected void grabCnx() {
     }
 
     private Void handleConnectionError(Throwable exception) {
-        exception.printStackTrace();
         log.warn("[{}] [{}] Error connecting to broker: {}", state.topic, state.getHandlerName(),
exception.getMessage());
         connection.connectionFailed(new PulsarClientException(exception));
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message