pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation
Date Thu, 13 Sep 2018 11:06:45 GMT
merlimat commented on a change in pull request #2535: Add ledger op timeout to avoid topics
stuck on ledger-creation
URL: https://github.com/apache/incubator-pulsar/pull/2535#discussion_r217344073
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
 ##########
 @@ -56,6 +56,7 @@
     private boolean autoSkipNonRecoverableData;
     private long offloadLedgerDeletionLagMs = TimeUnit.HOURS.toMillis(4);
     private long offloadAutoTriggerSizeThresholdBytes = -1;
+    private long opTimeoutSec = 5 * 60; //5 minutes
 
 Review comment:
   Maybe use a more explicit name like `metadataOperationsTimeoutSeconds` ? 
   
   Also, the default in `ServiceConfiguration` seems to be 60sec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message