pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2508: PIP-22: Dead Letter Topic
Date Thu, 13 Sep 2018 04:31:57 GMT
merlimat commented on a change in pull request #2508: PIP-22: Dead Letter Topic
URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r217257441
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
 ##########
 @@ -195,6 +195,7 @@ public void acknowledgeMessage(List<Position> positions, AckType
ackType, Map<St
                 log.debug("[{}][{}] Individual acks on {}", topicName, subName, positions);
             }
             cursor.asyncDelete(positions, deleteCallback, positions);
+            dispatcher.getRedeliveryTracker().removeBatch(positions);
 
 Review comment:
   This will not clean up the redelivery tracker when doing a "cumulative-ack". It should
be also cleaned at line 192, though for cumulative acks there might be a sequence of entries
to clean-up and the concurrent hash map might not be a good fit (since we'd need sorted map).
   
   Given that, and can we initially only enable the counter only on Shared subscriptions?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message