pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni opened a new pull request #2532: When WindowConfig is set, automatically default autoAck to false
Date Thu, 06 Sep 2018 18:32:46 GMT
srkukarni opened a new pull request #2532: When WindowConfig is set, automatically default
autoAck to false
URL: https://github.com/apache/incubator-pulsar/pull/2532
 
 
   ### Motivation
   
   We set the value of autoAck true by default. This is done so because users should not need
to set another variable when executing regular simple functions. However for window functions,
the window library does ack management by itself, which means autoAck should be set to false.
However this means that for submitting windowing functions, users have to explicitly set autoAck
to be false which is not the seemless experience. This pr automatically sets the autoAck to
false for window functions
   
   ### Modifications
   
   Describe the modifications you've done.
   
   ### Result
   
   After your change, what will change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message