From commits-return-13679-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Fri Aug 31 01:14:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 82E3E180675 for ; Fri, 31 Aug 2018 01:14:39 +0200 (CEST) Received: (qmail 17393 invoked by uid 500); 30 Aug 2018 23:14:38 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 17384 invoked by uid 99); 30 Aug 2018 23:14:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Aug 2018 23:14:38 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] rdhabalia opened a new pull request #2496: Fix: auto-ack flag always set true Message-ID: <153567087811.23398.5502148406218534898.gitbox@gitbox.apache.org> Date: Thu, 30 Aug 2018 23:14:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rdhabalia opened a new pull request #2496: Fix: auto-ack flag always set true URL: https://github.com/apache/incubator-pulsar/pull/2496 ### Motivation cli should have primitive boolean for any flag but it wasn't there for auto-ack because of that we were also setting auto-ack flag true. because of below logic ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services