From commits-return-13464-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Tue Aug 28 02:42:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99320180675 for ; Tue, 28 Aug 2018 02:42:38 +0200 (CEST) Received: (qmail 57179 invoked by uid 500); 28 Aug 2018 00:42:37 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 57170 invoked by uid 99); 28 Aug 2018 00:42:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Aug 2018 00:42:37 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] srkukarni closed pull request #2445: Remove schema validator from annotations Message-ID: <153541695719.28228.3393426632783159829.gitbox@gitbox.apache.org> Date: Tue, 28 Aug 2018 00:42:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srkukarni closed pull request #2445: Remove schema validator from annotations URL: https://github.com/apache/incubator-pulsar/pull/2445 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java index 63d8dd847a..ac96fa90a7 100644 --- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java +++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java @@ -29,7 +29,6 @@ import lombok.Getter; import lombok.Setter; import lombok.ToString; -import org.apache.pulsar.functions.api.Function; import org.apache.pulsar.functions.api.SerDe; import org.apache.pulsar.functions.utils.validation.ConfigValidation; @@ -82,8 +81,6 @@ private Map customSerdeInputs; @isValidTopicName private String topicsPattern; - @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class }, - valueValidatorClasses = { ValidatorImpls.SchemaValidator.class }, targetRuntime = ConfigValidation.Runtime.JAVA) @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class }, targetRuntime = ConfigValidation.Runtime.PYTHON) private Map customSchemaInputs; diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java index 6eb96c39e0..be886c41ae 100644 --- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java +++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java @@ -66,8 +66,7 @@ @isValidTopicName private String topicsPattern; - @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class }, - valueValidatorClasses = { ValidatorImpls.SchemaValidator.class }) + @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class }) private Map topicToSchemaType; private Map inputSpecs = new TreeMap<>(); diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java index 5807b403d6..38e200aefb 100644 --- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java +++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java @@ -58,7 +58,6 @@ @isImplementationOfClass(implementsClass = SerDe.class) private String serdeClassName; - @isImplementationOfClass(implementsClass = Schema.class) private String schemaType; private Map configs; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services