From commits-return-13386-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Mon Aug 27 18:55:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EFC0A180675 for ; Mon, 27 Aug 2018 18:55:38 +0200 (CEST) Received: (qmail 42993 invoked by uid 500); 27 Aug 2018 16:55:38 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 42968 invoked by uid 99); 27 Aug 2018 16:55:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Aug 2018 16:55:38 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #2451: Issue 2312: add python client multi-topics consumer support Message-ID: <153538893747.28925.13407785430799366385.gitbox@gitbox.apache.org> Date: Mon, 27 Aug 2018 16:55:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #2451: Issue 2312: add python client multi-topics consumer support URL: https://github.com/apache/incubator-pulsar/pull/2451#discussion_r213042192 ########## File path: pulsar-client-cpp/python/pulsar_test.py ########## @@ -650,6 +650,110 @@ def _v2_topics(self, url): client.close() + def test_topics_consumer(self): + client = Client(self.serviceUrl) + topic1 = 'persistent://sample/standalone/ns/my-python-topics-consumer-1' + topic2 = 'persistent://sample/standalone/ns/my-python-topics-consumer-2' + topic3 = 'persistent://sample/standalone/ns/my-python-topics-consumer-3' + topics = [topic1, topic2, topic3] + + url1 = self.adminUrl + '/admin/persistent/sample/standalone/ns/my-python-topics-consumer-1/partitions' + url2 = self.adminUrl + '/admin/persistent/sample/standalone/ns/my-python-topics-consumer-2/partitions' + url3 = self.adminUrl + '/admin/persistent/sample/standalone/ns/my-python-topics-consumer-3/partitions' + + doHttpPut(url1, '2') + doHttpPut(url2, '3') + doHttpPut(url3, '4') Review comment: As I mentioned in #2448, I think the multi-topic consumer in C++ is currently not working when there are no partitions in the topic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services