From commits-return-13021-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Tue Aug 21 00:12:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4C68718067C for ; Tue, 21 Aug 2018 00:12:33 +0200 (CEST) Received: (qmail 22785 invoked by uid 500); 20 Aug 2018 22:08:26 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 22776 invoked by uid 99); 20 Aug 2018 22:08:26 -0000 Received: from Unknown (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2018 22:08:26 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #2409: Added HDFS Sink Message-ID: <153480286092.26943.16924202344430548384.gitbox@gitbox.apache.org> Date: Mon, 20 Aug 2018 22:07:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#discussion_r211421759 ########## File path: pulsar-io/hdfs/src/main/java/org/apache/pulsar/io/hdfs/AbstractHdfsConfig.java ########## @@ -0,0 +1,172 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.hdfs; + +import java.io.Serializable; +import java.util.stream.Stream; + +import org.apache.commons.lang.StringUtils; +import org.apache.hadoop.io.compress.BZip2Codec; +import org.apache.hadoop.io.compress.CompressionCodec; +import org.apache.hadoop.io.compress.DeflateCodec; +import org.apache.hadoop.io.compress.GzipCodec; +import org.apache.hadoop.io.compress.Lz4Codec; +import org.apache.hadoop.io.compress.SnappyCodec; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import lombok.experimental.Accessors; + +@Data +@Setter +@Getter +@EqualsAndHashCode +@ToString +@Accessors(chain = true) +public abstract class AbstractHdfsConfig implements Serializable { + + public static final String BZIP2 = "BZip2"; + public static final String DEFLATE = "Deflate"; + public static final String GZIP = "Gzip"; + public static final String LZ4 = "Lz4"; + public static final String SNAPPY = "Snappy"; + + private static final long serialVersionUID = 1L; + + /** + * A file or comma separated list of files which contains the Hadoop file system configuration. Without this, Hadoop + * will search the classpath for a 'core-site.xml' and 'hdfs-site.xml' file or will revert to a default configuration. + */ + protected String hdfsConfigResources; Review comment: Fields should be marked as private (lombok generated getter/setters) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services