From commits-return-12252-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Thu Aug 2 16:04:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E77D3180629 for ; Thu, 2 Aug 2018 16:04:08 +0200 (CEST) Received: (qmail 44008 invoked by uid 500); 2 Aug 2018 14:04:08 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 43999 invoked by uid 99); 2 Aug 2018 14:04:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 14:04:08 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jiazhai commented on a change in pull request #2294: Add metrics to prometheus Message-ID: <153321864748.3566.3887502774754682445.gitbox@gitbox.apache.org> Date: Thu, 02 Aug 2018 14:04:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jiazhai commented on a change in pull request #2294: Add metrics to prometheus URL: https://github.com/apache/incubator-pulsar/pull/2294#discussion_r207237928 ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java ########## @@ -6,9 +6,9 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * + *

Review comment: Seems this change will make the jenkins fail to recognise the header. Please change it back. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services