pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java Client Interceptors.
Date Thu, 30 Aug 2018 02:37:23 GMT
codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213888826
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
 ##########
 @@ -435,7 +451,7 @@ private void doBatchSendAndAdd(MessageImpl<T> msg, SendCallback
callback, ByteBu
         payload.release();
     }
 
-    private boolean isValidProducerState(SendCallback callback) {
+    private boolean isValidProducerState(Message<T> message, SendCallback callback)
{
 
 Review comment:
   Unused code. I will delete it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message