pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2471: Pulsar Java Client Interceptors.
Date Wed, 29 Aug 2018 18:28:42 GMT
merlimat commented on a change in pull request #2471: Pulsar Java Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213770348
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
 ##########
 @@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import org.apache.pulsar.client.api.Consumer;
+import org.apache.pulsar.client.api.ConsumerInterceptor;
+import org.apache.pulsar.client.api.Message;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.MessageListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * A container that hold the list {@link org.apache.pulsar.client.api.ConsumerInterceptor}
and wraps calls to the chain
+ * of custom interceptors.
+ */
+public class ConsumerInterceptors<T> implements Closeable {
+
+    private static final Logger log = LoggerFactory.getLogger(ConsumerInterceptors.class);
+
+    private final List<ConsumerInterceptor<T>> interceptors;
+
+    public ConsumerInterceptors(List<ConsumerInterceptor<T>> interceptors) {
+        this.interceptors = interceptors;
+    }
+
+    /**
+     * This is called just before the message is returned by {@link Consumer#receive()},
+     * {@link MessageListener#received(Consumer, Message)} or the {@link java.util.concurrent.CompletableFuture}
+     * returned by {@link Consumer#receiveAsync()} completes.
+     * <p>
+     * This method calls {@link ConsumerInterceptor#beforeConsume(Message)} for each interceptor.
Messages returned
+     * from each interceptor get passed to beforeConsume() of the next interceptor in the
chain of interceptors.
+     * <p>
+     * This method does not throw exceptions. If any of the interceptors in the chain throws
an exception, it gets
+     * caught and logged, and next interceptor in int the chain is called with 'messages'
returned by the previous
+     * successful interceptor beforeConsume call.
+     *
+     * @param message message to be consume by the client.
+     * @return messages that are either modified by interceptors or same as messages passed
to this method.
+     */
+    public Message<T> beforeConsume(Message<T> message) {
+        Message<T> interceptorMessage = message;
+        for (ConsumerInterceptor<T> interceptor : this.interceptors) {
 
 Review comment:
   Since this is called per-each message, we could avoid creating the implicit list iterator
by doing old-school `for (int i = 0; i < interceptor.size()....`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message