pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2468: Fix semantics of skip output
Date Wed, 29 Aug 2018 07:48:56 GMT
sijie commented on a change in pull request #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468#discussion_r213576537
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -477,9 +477,8 @@ void processArguments() throws Exception {
 
         protected void validateFunctionConfigs(FunctionConfig functionConfig) {
 
-            if (isBlank(functionConfig.getOutput()) && !functionConfig.isSkipOutput())
{
-                throw new ParameterException(
 
 Review comment:
   didn't we agree on #2261 to fail-fast if no output specified and if user want to skip output,
they should skip-output?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message