pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni opened a new pull request #2468: Fix semantics of skip output
Date Tue, 28 Aug 2018 19:01:14 GMT
srkukarni opened a new pull request #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468
 
 
   ### Motivation
   
   skipOutput is meant to supress any output if set to true. The current check are inaccurate
in two respects
   1. If the flag is set to true, then we need to set output topic to empty(i.e. no output).
This pr does it
   2. The current check does not work for void functions.
   ### Modifications
   
   Describe the modifications you've done.
   
   ### Result
   
   After your change, what will change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message