pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie closed pull request #2380: Increase default maxConcurrentLookupRequests to 50k
Date Tue, 28 Aug 2018 17:41:16 GMT
sijie closed pull request #2380: Increase default maxConcurrentLookupRequests to 50k
URL: https://github.com/apache/incubator-pulsar/pull/2380
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/conf/broker.conf b/conf/broker.conf
index 427d848264..6a0a706d71 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -152,7 +152,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup
traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
@@ -542,4 +542,3 @@ gcsManagedLedgerOffloadServiceAccountKeyFile=
 
 # Deprecated. Use configurationStoreServers
 globalZookeeperServers=
-
diff --git a/conf/proxy.conf b/conf/proxy.conf
index 7b7e690478..9b307ccdc7 100644
--- a/conf/proxy.conf
+++ b/conf/proxy.conf
@@ -81,7 +81,7 @@ forwardAuthorizationCredentials=false
 maxConcurrentInboundConnections=10000
 
 # Max concurrent outbound connections. The proxy will error out requests beyond that.
-maxConcurrentLookupRequests=10000
+maxConcurrentLookupRequests=50000
 
 ##### --- TLS --- #####
 
diff --git a/conf/standalone.conf b/conf/standalone.conf
index cc03b958d2..a9fb2884f3 100644
--- a/conf/standalone.conf
+++ b/conf/standalone.conf
@@ -141,7 +141,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup
traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
diff --git a/deployment/terraform-ansible/templates/broker.conf b/deployment/terraform-ansible/templates/broker.conf
index 8e8c6c2ac5..a4fad1c98e 100644
--- a/deployment/terraform-ansible/templates/broker.conf
+++ b/deployment/terraform-ansible/templates/broker.conf
@@ -152,7 +152,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup
traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
diff --git a/deployment/terraform-ansible/templates/proxy.conf b/deployment/terraform-ansible/templates/proxy.conf
index 21fa327f9b..b631acaad7 100644
--- a/deployment/terraform-ansible/templates/proxy.conf
+++ b/deployment/terraform-ansible/templates/proxy.conf
@@ -81,7 +81,7 @@ forwardAuthorizationCredentials=false
 maxConcurrentInboundConnections=10000
 
 # Max concurrent outbound connections. The proxy will error out requests beyond that.
-maxConcurrentLookupRequests=10000
+maxConcurrentLookupRequests=50000
 
 ##### --- TLS --- #####
 
diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
index 9efa2a62e0..245920c115 100644
--- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
+++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -170,7 +170,7 @@
     private boolean dispatchThrottlingOnNonBacklogConsumerEnabled = false;
     // Max number of concurrent lookup request broker allows to throttle heavy incoming lookup
traffic
     @FieldContext(dynamic = true)
-    private int maxConcurrentLookupRequest = 10000;
+    private int maxConcurrentLookupRequest = 50000;
     // Max number of concurrent topic loading request broker allows to control number of
zk-operations
     @FieldContext(dynamic = true)
     private int maxConcurrentTopicLoadRequest = 5000;
diff --git a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
index 4d027867cf..b4e8afb7c2 100644
--- a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
+++ b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
@@ -82,7 +82,7 @@
     private int maxConcurrentInboundConnections = 10000;
 
     // Max concurrent outbound Connections
-    private int maxConcurrentLookupRequests = 10000;
+    private int maxConcurrentLookupRequests = 50000;
 
     // Authentication settings of the proxy itself. Used to connect to brokers
     private String brokerClientAuthenticationPlugin;
diff --git a/site2/docs/administration-proxy.md b/site2/docs/administration-proxy.md
index e4e1a86f52..3321e80cb3 100644
--- a/site2/docs/administration-proxy.md
+++ b/site2/docs/administration-proxy.md
@@ -56,7 +56,7 @@ The Pulsar proxy can be configured using the [`proxy.conf`](reference-configurat
 |superUserRoles|  Role names that are treated as “super-users,” meaning that they will
be able to perform all admin ||
 |forwardAuthorizationCredentials| Whether client authorization credentials are forwared to
the broker for re-authorization. Authentication must be enabled via authenticationEnabled=true
for this to take effect.  |false|
 |maxConcurrentInboundConnections| Max concurrent inbound connections. The proxy will reject
requests beyond that. |10000|
-|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out
requests beyond that. |10000|
+|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out
requests beyond that. |50000|
 |tlsEnabledInProxy| Whether TLS is enabled for the proxy  |false|
 |tlsEnabledWithBroker|  Whether TLS is enabled when communicating with Pulsar brokers |false|
 |tlsCertificateFilePath|  Path for the TLS certificate file ||
diff --git a/site2/docs/reference-configuration.md b/site2/docs/reference-configuration.md
index c5a47383cd..b74a928bca 100644
--- a/site2/docs/reference-configuration.md
+++ b/site2/docs/reference-configuration.md
@@ -142,7 +142,7 @@ Pulsar brokers are responsible for handling incoming messages from producers,
di
 |tlsAllowInsecureConnection|  Accept untrusted TLS certificate from client  |false|
 |maxUnackedMessagesPerConsumer| Max number of unacknowledged messages allowed to receive
messages by a consumer on a shared subscription. Broker will stop sending messages to consumer
once, this limit reaches until consumer starts acknowledging messages back. Using a value
of 0, is disabling unackeMessage limit check and consumer can receive messages without any
restriction  |50000|
 |maxUnackedMessagesPerSubscription| Max number of unacknowledged messages allowed per shared
subscription. Broker will stop dispatching messages to all consumers of the subscription once
this limit reaches until consumer starts acknowledging messages back and unack count reaches
to limit/2. Using a value of 0, is disabling unackedMessage-limit check and dispatcher can
dispatch messages without any restriction  |200000|
-|maxConcurrentLookupRequest|  Max number of concurrent lookup request broker allows to throttle
heavy incoming lookup traffic |10000|
+|maxConcurrentLookupRequest|  Max number of concurrent lookup request broker allows to throttle
heavy incoming lookup traffic |50000|
 |maxConcurrentTopicLoadRequest| Max number of concurrent topic loading request broker allows
to control number of zk-operations |5000|
 |authenticationEnabled| Enable authentication |false|
 |authenticationProviders| Autentication provider name list, which is comma separated list
of class names  ||
@@ -426,7 +426,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can
be config
 |superUserRoles|  Role names that are treated as “super-users,” meaning that they will
be able to perform all admin ||
 |forwardAuthorizationCredentials| Whether client authorization credentials are forwared to
the broker for re-authorization. Authentication must be enabled via authenticationEnabled=true
for this to take effect.  |false|
 |maxConcurrentInboundConnections| Max concurrent inbound connections. The proxy will reject
requests beyond that. |10000|
-|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out
requests beyond that. |10000|
+|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out
requests beyond that. |50000|
 |tlsEnabledInProxy| Whether TLS is enabled for the proxy  |false|
 |tlsEnabledWithBroker|  Whether TLS is enabled when communicating with Pulsar brokers |false|
 |tlsCertificateFilePath|  Path for the TLS certificate file ||


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message