pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sanjee...@apache.org
Subject [incubator-pulsar] branch master updated: Remove schema validator from annotations since it requires slightly more information (#2445)
Date Tue, 28 Aug 2018 00:42:38 GMT
This is an automated email from the ASF dual-hosted git repository.

sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new b234f33  Remove schema validator from annotations since it requires slightly more
information (#2445)
b234f33 is described below

commit b234f330ec6600c7ffd2201d4360182a5bd4d0b7
Author: Sanjeev Kulkarni <sanjeevrk@gmail.com>
AuthorDate: Mon Aug 27 17:42:35 2018 -0700

    Remove schema validator from annotations since it requires slightly more information (#2445)
    
    and is therefore done explitcly
---
 .../main/java/org/apache/pulsar/functions/utils/FunctionConfig.java    | 3 ---
 .../src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java    | 3 +--
 .../src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java  | 1 -
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
index 63d8dd8..ac96fa9 100644
--- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
+++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
@@ -29,7 +29,6 @@ import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.ToString;
-import org.apache.pulsar.functions.api.Function;
 import org.apache.pulsar.functions.api.SerDe;
 import org.apache.pulsar.functions.utils.validation.ConfigValidation;
 
@@ -82,8 +81,6 @@ public class FunctionConfig {
     private Map<String, String> customSerdeInputs;
     @isValidTopicName
     private String topicsPattern;
-    @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class },
-            valueValidatorClasses = { ValidatorImpls.SchemaValidator.class }, targetRuntime
= ConfigValidation.Runtime.JAVA)
     @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class },
targetRuntime = ConfigValidation.Runtime.PYTHON)
     private Map<String, String> customSchemaInputs;
 
diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java
b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java
index 6eb96c3..be886c4 100644
--- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java
+++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfig.java
@@ -66,8 +66,7 @@ public class SinkConfig {
     @isValidTopicName
     private String topicsPattern;
 
-    @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class },
-            valueValidatorClasses = { ValidatorImpls.SchemaValidator.class })
+    @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class })
     private Map<String, String> topicToSchemaType;
 
     private Map<String, ConsumerConfig> inputSpecs = new TreeMap<>();
diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java
b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java
index 5807b40..38e200a 100644
--- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java
+++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java
@@ -58,7 +58,6 @@ public class SourceConfig {
     @isImplementationOfClass(implementsClass = SerDe.class)
     private String serdeClassName;
 
-    @isImplementationOfClass(implementsClass = Schema.class)
     private String schemaType;
 
     private Map<String, Object> configs;


Mime
View raw message