pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2451: Issue 2312: add python client multi-topics consumer support
Date Mon, 27 Aug 2018 16:53:55 GMT
merlimat commented on a change in pull request #2451: Issue 2312: add python client multi-topics
consumer support
URL: https://github.com/apache/incubator-pulsar/pull/2451#discussion_r213041782
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/__init__.py
 ##########
 @@ -503,6 +503,211 @@ def my_listener(consumer, message):
         self._consumers.append(c)
         return c
 
+    def subscribe_topics(self, topics, subscription_name,
 
 Review comment:
   @jiazhai I'd prefer to keep a single `subscribe()` method. In python we can check the type
of the argument `topic` and detect whether is a string, a list or a regex object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message