pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2440: Issue 2313: create a JDBC sink connector
Date Fri, 24 Aug 2018 18:33:31 GMT
sijie commented on a change in pull request #2440: Issue 2313: create a JDBC sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#discussion_r212717203
 
 

 ##########
 File path: tests/integration/pom.xml
 ##########
 @@ -78,6 +78,20 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
+
+    <dependency>
+      <groupId>org.testcontainers</groupId>
+      <artifactId>mysql</artifactId>
+      <version>1.8.3</version>
 
 Review comment:
   define `org.testcontainers:mysql` in root pom. so you don't need include version here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message