pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni closed pull request #2439: leak assign schema in MessageImpl constructor
Date Fri, 24 Aug 2018 03:42:57 GMT
srkukarni closed pull request #2439: leak assign schema in MessageImpl constructor
URL: https://github.com/apache/incubator-pulsar/pull/2439

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
index 5ea8bfef5e..96b68c1af4 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
@@ -155,6 +155,7 @@ public MessageImpl(String msgId, Map<String, String> properties,
ByteBuf payload
         this.cnx = null;
         this.payload = payload;
         this.properties = Collections.unmodifiableMap(properties);
+        this.schema = schema;
     public static MessageImpl<byte[]> deserialize(ByteBuf headersAndPayload) throws
IOException {


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message