pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2428: Package Presto with Pulsar for SQL integration
Date Thu, 23 Aug 2018 17:13:22 GMT
sijie commented on a change in pull request #2428: Package Presto with Pulsar for SQL integration
URL: https://github.com/apache/incubator-pulsar/pull/2428#discussion_r212387727
 
 

 ##########
 File path: pulsar-sql/presto-server/src/resources/etc/catalog/pulsar.properties
 ##########
 @@ -0,0 +1,5 @@
+connector.name=pulsar
 
 Review comment:
   any reason why we can't place /etc/catalog/pulsar.properties to conf/presto/catalog/pulsar.properties?
then we have a central place for managing all configuration files for pulsar components.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message