pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python client
Date Tue, 21 Aug 2018 22:31:46 GMT
sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python
client
URL: https://github.com/apache/incubator-pulsar/pull/2423
 
 
    ### Motivation
   
   This is a caught-up change to enable properties for consumer as java clients.
   
    ### Changes
   
   Enable properties on consumer for both cpp & python client
   
    ### Results
   
   Properties are added as metadata for CommandSubscribe. However there is no way
   to verify the consumer properties. so I didn't add any specific tests, just
   adding properties for both cpp and python clients in the tests, that should
   excerise the corresponding code path.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message