pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema
Date Tue, 21 Aug 2018 04:37:08 GMT
jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema
URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211476103
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
 ##########
 @@ -469,20 +477,56 @@ protected FunctionDetails createSinkConfig(SinkConfig sinkConfig) throws
IOExcep
             // set source spec
             // source spec classname should be empty so that the default pulsar source will
be used
             SourceSpec.Builder sourceSpecBuilder = SourceSpec.newBuilder();
+            sourceSpecBuilder.setSubscriptionType(Function.SubscriptionType.SHARED);
 
 Review comment:
   we should at least hide --customSerdeInputs since serdes are deprecated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message