pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema
Date Mon, 20 Aug 2018 18:39:57 GMT
sijie commented on a change in pull request #2397: Integrate Functions with Schema
URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211363297
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
 ##########
 @@ -246,6 +263,7 @@ void processArguments() throws Exception {
             } else {
                 this.sinkConfig = new SinkConfig();
             }
+            log.info("The sinkConfig read from file is {}", sinkConfig);
 
 Review comment:
   This logging looks like for debugging purpose. I think it can be removed.
   
   If you want to keep it, it should be moved to after line 262.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message