pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2266: Integrate functions and io with schema registry
Date Thu, 16 Aug 2018 14:52:50 GMT
jerrypeng commented on a change in pull request #2266: Integrate functions and io with schema
registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r210615501
 
 

 ##########
 File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
 ##########
 @@ -71,19 +66,19 @@
     private String name;
     @NotNull
     private String className;
-    @isListEntryCustom(entryValidatorClasses = {ValidatorImpls.TopicNameValidator.class})
-    private Collection<String> inputs;
-    @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class },
-            valueValidatorClasses = { ValidatorImpls.SerdeValidator.class }, targetRuntime
= ConfigValidation.Runtime.JAVA)
-    @isMapEntryCustom(keyValidatorClasses = { ValidatorImpls.TopicNameValidator.class },
targetRuntime = ConfigValidation.Runtime.PYTHON)
-    private Map<String, String> customSerdeInputs;
-    @isValidTopicName
-    private String topicsPattern;
+
+    private Map<String, ConsumerConfig> inputSpecs = new TreeMap<>();
 
 Review comment:
   FunctionConfig is also used to parse function config yaml files that the user can submit
instead of cli args.  This makes it very difficult for users to specify inputs.  This is also
breaking backwards compatibility for users have have a function config file that uses the
"inputs" fields

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message