pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2266: Integrate functions and io with schema registry
Date Thu, 16 Aug 2018 06:38:10 GMT
merlimat commented on a change in pull request #2266: Integrate functions and io with schema
registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r210489745
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
 ##########
 @@ -207,10 +201,18 @@ void runCmd() throws Exception {
 
         @Parameter(names = "--processingGuarantees", description = "The processing guarantees
(aka delivery semantics) applied to the Source")
         protected FunctionConfig.ProcessingGuarantees processingGuarantees;
-        @Parameter(names = "--destinationTopicName", description = "The Pulsar topic to which
data is sent")
+
+        @Parameter(names = { "-o", "--destinationTopicName" }, description = "The Pulsar
topic to which data is sent")
         protected String destinationTopicName;
-        @Parameter(names = "--deserializationClassName", description = "The SerDe classname
for the source")
+
+        @Parameter(names = "--deserializationClassName", description = "The SerDe classname
for the source", hidden = true)
         protected String deserializationClassName;
 
 Review comment:
   That will come in @jerrypeng PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message