pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2376: adding tiered storage confs to endpoint
Date Wed, 15 Aug 2018 15:56:10 GMT
merlimat commented on a change in pull request #2376: adding tiered storage confs to endpoint
URL: https://github.com/apache/incubator-pulsar/pull/2376#discussion_r210317205
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/conf/InternalConfigurationData.java
 ##########
 @@ -58,7 +66,8 @@ public boolean equals(Object obj) {
         InternalConfigurationData other = (InternalConfigurationData) obj;
 
 Review comment:
   We could just use lombok to generate equals and toString methods

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message