pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2367: [compaction] make topic compaction works with partitioned topic
Date Tue, 14 Aug 2018 08:50:03 GMT
sijie commented on a change in pull request #2367: [compaction] make topic compaction works
with partitioned topic
URL: https://github.com/apache/incubator-pulsar/pull/2367#discussion_r209873448
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java
 ##########
 @@ -105,7 +105,6 @@ private void phaseOneLoop(RawReader reader,
             return;
         }
         CompletableFuture<RawMessage> future = reader.readNextAsync();
-        scheduleTimeout(future);
 
 Review comment:
   brought the timeout back. Although it is not perfect. will look into how to improve this
later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message