pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2350: C++ HTTP lookup works with TLS (#2314)
Date Thu, 09 Aug 2018 18:59:33 GMT
merlimat commented on a change in pull request #2350: C++ HTTP lookup works with TLS (#2314)
URL: https://github.com/apache/incubator-pulsar/pull/2350#discussion_r209043509
 
 

 ##########
 File path: pulsar-client-cpp/lib/HTTPLookupService.cc
 ##########
 @@ -186,6 +189,36 @@ Result HTTPLookupService::sendHTTPRequest(const std::string completeUrl,
std::st
     }
     curl_easy_setopt(handle, CURLOPT_HTTPHEADER, list);
 
+    // TLS
+    if (isUseTls_) {
+        if(curl_easy_setopt(handle, CURLOPT_SSLENGINE, NULL) != CURLE_OK) {
 
 Review comment:
   Missing space here is making format validator to fail

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message