pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry
Date Tue, 07 Aug 2018 18:01:19 GMT
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema
registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r208328869
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -226,30 +228,32 @@ void processArguments() throws Exception {
                 description = "Path to the main Python file for the function (if the function
is written in Python)",
                 listConverter = StringConverter.class)
         protected String pyFile;
-        @Parameter(names = "--inputs", description = "The function's input topic or topics
(multiple topics can be specified as a comma-separated list)")
+        @Parameter(names = { "-i",
+                "--inputs" }, description = "The function's input topic or topics (multiple
topics can be specified as a comma-separated list)")
         protected String inputs;
         // for backwards compatibility purposes
         @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from
list of topics under a namespace that match the pattern. [--input] and [--topic-pattern] are
mutually exclusive. Add SerDe class name for a pattern in --custom-serde-inputs (supported
for java fun only)", hidden = true)
         protected String DEPRECATED_topicsPattern;
         @Parameter(names = "--topics-pattern", description = "The topic pattern to consume
from list of topics under a namespace that match the pattern. [--input] and [--topic-pattern]
are mutually exclusive. Add SerDe class name for a pattern in --custom-serde-inputs (supported
for java fun only)")
         protected String topicsPattern;
-        @Parameter(names = "--output", description = "The function's output topic")
+
+        @Parameter(names = {"-o", "--output"}, description = "The function's output topic")
         protected String output;
         // for backwards compatibility purposes
         @Parameter(names = "--logTopic", description = "The topic to which the function's
logs are produced", hidden = true)
         protected String DEPRECATED_logTopic;
         @Parameter(names = "--log-topic", description = "The topic to which the function's
logs are produced")
         protected String logTopic;
+
+        @Parameter(names = {"-st", "--schema-type"}, description = "The builtin schema type
or custom schema class name to be used for messages output by the function")
+        protected String schemaTypeOrClassName = "";
+
         // for backwards compatibility purposes
         @Parameter(names = "--customSerdeInputs", description = "The map of input topics
to SerDe class names (as a JSON string)", hidden = true)
 
 Review comment:
   makes sense

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message