pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #2214: Add tls support to authenticate client to access function admin-api
Date Thu, 02 Aug 2018 22:13:29 GMT
rdhabalia commented on a change in pull request #2214: Add tls support to authenticate client
to access function admin-api
URL: https://github.com/apache/incubator-pulsar/pull/2214#discussion_r207391189
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java
 ##########
 @@ -96,7 +136,6 @@ public void run() {
             log.error("ex: {}", ex, ex);
             final String message = getErrorMessage(server, this.workerConfig.getWorkerPort(),
ex);
             log.error(message);
-            System.exit(1);
 
 Review comment:
   that's fine. let me disable test for now.. will create a PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message