pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2261: Avoid creating output topic on tenant namespace if output-topic not provided
Date Thu, 02 Aug 2018 00:03:07 GMT
jerrypeng commented on a change in pull request #2261: Avoid creating output topic on tenant
namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r207067820
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig functionConfig) {
             if (StringUtils.isEmpty(functionConfig.getNamespace())) {
                 inferMissingNamespace(functionConfig);
             }
-            if (StringUtils.isEmpty(functionConfig.getOutput())) {
 
 Review comment:
   I don't think we should implicitly create a topic for the output.  I think it makes more
since for the the user to explicitly specify it. The user might even be confused if he or
she can submit a function without a output topic.  He or she might not even know what the
default output topic name will be.  
   
   If we really want to create a default output topic automatically for the function, lets
at least check that the function is set to return a non-void type.  There is no point to create
automatically creating an output topic if the function is set to return void 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message