pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2273: rename args in CmdFunctions to be consistent with existing CLI arg naming conventions in pulsar
Date Wed, 01 Aug 2018 23:23:57 GMT
jerrypeng commented on a change in pull request #2273: rename args in CmdFunctions to be consistent
with existing CLI arg naming conventions in pulsar
URL: https://github.com/apache/incubator-pulsar/pull/2273#discussion_r207061790
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -224,21 +227,42 @@ void processArguments() throws Exception {
         protected String pyFile;
         @Parameter(names = "--inputs", description = "The function's input topic or topics
(multiple topics can be specified as a comma-separated list)")
         protected String inputs;
-        @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from
list of topics under a namespace that match the pattern. [--input] and [--topicsPattern] are
mutually exclusive. Add SerDe class name for a pattern in --customSerdeInputs (supported for
java fun only)")
+        // for backwards compatibility purposes
+        @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from
list of topics under a namespace that match the pattern. [--input] and [--topic-pattern] are
mutually exclusive. Add SerDe class name for a pattern in --custom-serde-inputs (supported
for java fun only)", hidden = true)
 
 Review comment:
   I think the correct working is probably "--topic-pattern", however in FunctionConfig we
declare the variable topicsPattern.  If we what to change "--topics-pattern" to "--topic-pattern",
we should probably change that in FunctionConfig as well which will be a bigger change.  Thus,
I chose not to change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message