From commits-return-11065-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Fri Jul 13 18:37:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8AD1418077A for ; Fri, 13 Jul 2018 18:37:49 +0200 (CEST) Received: (qmail 54882 invoked by uid 500); 13 Jul 2018 16:37:48 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 54823 invoked by uid 99); 13 Jul 2018 16:37:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 16:37:48 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers Message-ID: <153149986807.25863.488070833296654118.gitbox@gitbox.apache.org> Date: Fri, 13 Jul 2018 16:37:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202401733 ########## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java ########## @@ -136,52 +173,38 @@ public void start() throws Exception { "bin/init-cluster.sh"); log.info("Successfully initialized the cluster."); - // create bookies - bookieContainers.putAll( - runNumContainers("bookie", spec.numBookies(), (name) -> new BKContainer(clusterName, name) - .withNetwork(network) - .withNetworkAliases(name) - .withEnv("zkServers", ZKContainer.NAME) - .withEnv("useHostNameAsBookieID", "true") - .withEnv("clusterName", clusterName) - ) - ); + // start bookies + bookieContainers.values().stream().forEach(BKContainer::start); + log.info("Successfully started {} bookie conntainers.", bookieContainers.values().size()); - // create brokers - brokerContainers.putAll( - runNumContainers("broker", spec.numBrokers(), (name) -> new BrokerContainer(clusterName, name) - .withNetwork(network) - .withNetworkAliases(name) - .withEnv("zkServers", ZKContainer.NAME) - .withEnv("zookeeperServers", ZKContainer.NAME) - .withEnv("configurationStoreServers", CSContainer.NAME + ":" + CS_PORT) - .withEnv("clusterName", clusterName) - .withEnv("brokerServiceCompactionMonitorIntervalInSeconds", "1") - ) - ); + // start brokers + brokerContainers.values().stream().forEach(BrokerContainer::start); + log.info("Successfully started {} broker conntainers.", brokerContainers.values().size()); // create proxy proxyContainer.start(); log.info("Successfully started pulsar proxy."); + if(spec.enableTieredStorage()){ Review comment: spacing ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services