pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2259: Fix: set subscription-type based on message ordering
Date Mon, 30 Jul 2018 18:32:24 GMT
srkukarni commented on a change in pull request #2259: Fix: set subscription-type based on
message ordering
URL: https://github.com/apache/incubator-pulsar/pull/2259#discussion_r206276685
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -240,6 +240,8 @@ void processArguments() throws Exception {
         protected FunctionConfig.ProcessingGuarantees processingGuarantees;
         @Parameter(names = "--userConfig", description = "User-defined config key/values")
         protected String userConfigString;
+        @Parameter(names = "--retainOrdering", description = "Function consumes and processes
messages in order")
 
 Review comment:
   Do we think that actually specifying subscription type might be the way to go here. We
used to have that flag but removed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message