pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2261: Avoid creating output topic on tenant namespace if output-topic not provided
Date Mon, 30 Jul 2018 18:31:05 GMT
srkukarni commented on a change in pull request #2261: Avoid creating output topic on tenant
namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r206276301
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig functionConfig) {
             if (StringUtils.isEmpty(functionConfig.getNamespace())) {
                 inferMissingNamespace(functionConfig);
             }
-            if (StringUtils.isEmpty(functionConfig.getOutput())) {
 
 Review comment:
   When we made this flag optional, the intention was that the user need to specify as few
arguments as necessary and the system takes care of most of the arguments. Essentially design
for user simplicity. That's why I felt if one needs an optimization, that might be a flag.
   I'm curious what @sijie @jerrypeng feel about this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message