pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2261: Avoid creating output topic on tenant namespace if output-topic not provided
Date Mon, 30 Jul 2018 18:15:17 GMT
srkukarni commented on a change in pull request #2261: Avoid creating output topic on tenant
namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r206271389
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig functionConfig) {
             if (StringUtils.isEmpty(functionConfig.getNamespace())) {
                 inferMissingNamespace(functionConfig);
             }
-            if (StringUtils.isEmpty(functionConfig.getOutput())) {
 
 Review comment:
   I would rather have this functionality gated by some kind of flag with default being output
topic created that the users can turn off for optimization purposes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message